[GitHub] servicemix-bundles pull request #103: Create OSGi bundle for Apache Tinkerpo...

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] servicemix-bundles pull request #103: Create OSGi bundle for Apache Tinkerpo...

LaurentTrk
GitHub user CMoH opened a pull request:

    https://github.com/apache/servicemix-bundles/pull/103

    Create OSGi bundle for Apache Tinkerpop 3.2.4 - gremlin-driver-shaded

    Shade gremlin-driver, gremlin-core and gremlin-shaded modules from tinkerpop into a single bundle, together with non-OSGi 3rd-party deps
   
    The object of this bundle is to allow remote tinkerpop servers to be accessed from OSGi environments, as I showcased here: https://github.com/CMoH/tinkerpop-osgi-samples

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/CMoH/servicemix-bundles tinkerpop-shaded

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/servicemix-bundles/pull/103.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #103
   
----
commit f597e3f99f62cdd367d47fff5810da8d334e8a30
Author: Ciprian Ciubotariu <[hidden email]>
Date:   2017-07-21T00:48:34Z

    Create OSGi bundle for Apache Tinkerpop 3.2.4 - gremlin-driver-shaded
   
    Shade gremlin-driver, gremlin-core and gremlin-shaded modules from
    tinkerpop into a single bundle, together with non-OSGi 3rd-party deps

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] servicemix-bundles pull request #103: Create OSGi bundle for Apache Tinkerpo...

LaurentTrk
Github user jbonofre commented on a diff in the pull request:

    https://github.com/apache/servicemix-bundles/pull/103#discussion_r128984009
 
    --- Diff: gremlin-driver-3.2.4-shaded/pom.xml ---
    @@ -0,0 +1,98 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +
    +    <!--
    +
    +        Licensed to the Apache Software Foundation (ASF) under one or more
    +        contributor license agreements.  See the NOTICE file distributed with
    +        this work for additional information regarding copyright ownership.
    +        The ASF licenses this file to You under the Apache License, Version 2.0
    +        (the "License"); you may not use this file except in compliance with
    +        the License.  You may obtain a copy of the License at
    +
    +           http://www.apache.org/licenses/LICENSE-2.0
    +
    +        Unless required by applicable law or agreed to in writing, software
    +        distributed under the License is distributed on an "AS IS" BASIS,
    +        WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +        See the License for the specific language governing permissions and
    +        limitations under the License.
    +    -->
    +
    +    <modelVersion>4.0.0</modelVersion>
    +
    +    <parent>
    +        <groupId>org.apache.servicemix.bundles</groupId>
    +        <artifactId>bundles-pom</artifactId>
    +        <version>13</version>
    +        <relativePath>../bundles-pom/pom.xml</relativePath>
    +    </parent>
    +
    +    <groupId>org.apache.servicemix.bundles</groupId>
    +    <artifactId>org.apache.servicemix.bundles.gremlin-driver-shaded</artifactId>
    +    <version>3.2.4_1-SNAPSHOT</version>
    +    <packaging>bundle</packaging>
    +    <name>Apache ServiceMix :: Bundles :: ${pkgArtifactIdShaded}</name>
    +    <description>This OSGi bundle wraps ${pkgArtifactId} ${pkgVersion} shaded jar file.</description>
    +
    --- End diff --
   
    For the record, the `<scm/>` section is required for the release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] servicemix-bundles pull request #103: Create OSGi bundle for Apache Tinkerpo...

LaurentTrk
In reply to this post by LaurentTrk
Github user asfgit closed the pull request at:

    https://github.com/apache/servicemix-bundles/pull/103


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---