[GitHub] servicemix-bundles pull request #104: [FIX] Update org.springframework.ldap ...

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] servicemix-bundles pull request #104: [FIX] Update org.springframework.ldap ...

LaurentTrk
GitHub user LaurentTrk opened a pull request:

    https://github.com/apache/servicemix-bundles/pull/104

    [FIX] Update org.springframework.ldap version

    org.springframework.ldap is still in version 2.x (last one is 2.3.1)
    Change is needed to use ldap classes


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ENOVACOM/servicemix-bundles master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/servicemix-bundles/pull/104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #104
   
----
commit 3a1609ade645ac1bfb7d3063a7c0de258308bd2e
Author: LaurentTrk <[hidden email]>
Date:   2017-08-03T10:24:21Z

    [FIX] Update org.springframework.ldap version
   
    org.springframework.ldap is still in version 2.x

commit 65c0ef5b9c3b8aadcc1fddfb046b321a66f7bd0e
Author: LaurentTrk <[hidden email]>
Date:   2017-08-03T10:25:51Z

    Merge pull request #1 from ENOVACOM/Fix-Spring-LDAP-Version
   
    [FIX] Update org.springframework.ldap version

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] servicemix-bundles pull request #104: [FIX] Update org.springframework.ldap ...

LaurentTrk
Github user jbonofre commented on a diff in the pull request:

    https://github.com/apache/servicemix-bundles/pull/104#discussion_r131149193
 
    --- Diff: spring-security-ldap-4.2.3.RELEASE/pom.xml ---
    @@ -72,7 +72,7 @@
                 org.springframework.jdbc.core;resolution:=optional;version="[4,5)",
                 org.springframework.jdbc.core.support;resolution:=optional;version="[4,5)",
                 org.springframework.util;resolution:=optional;version="[4,5)",
    -            org.springframework.ldap*;resolution:=optional;version="[4,5)",
    +            org.springframework.ldap*;resolution:=optional;version="[2,3)",
    --- End diff --
   
    Maybe we can extend to `[2,5)` to support larger range ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] servicemix-bundles pull request #104: [FIX] Update org.springframework.ldap ...

LaurentTrk
In reply to this post by LaurentTrk
Github user LaurentTrk commented on a diff in the pull request:

    https://github.com/apache/servicemix-bundles/pull/104#discussion_r131149612
 
    --- Diff: spring-security-ldap-4.2.3.RELEASE/pom.xml ---
    @@ -72,7 +72,7 @@
                 org.springframework.jdbc.core;resolution:=optional;version="[4,5)",
                 org.springframework.jdbc.core.support;resolution:=optional;version="[4,5)",
                 org.springframework.util;resolution:=optional;version="[4,5)",
    -            org.springframework.ldap*;resolution:=optional;version="[4,5)",
    +            org.springframework.ldap*;resolution:=optional;version="[2,3)",
    --- End diff --
   
    Hi @jbonofre,
    For sure, up to you !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] servicemix-bundles pull request #104: [FIX] Update org.springframework.ldap ...

LaurentTrk
In reply to this post by LaurentTrk
Github user asfgit closed the pull request at:

    https://github.com/apache/servicemix-bundles/pull/104


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---