[GitHub] servicemix-bundles pull request #129: SM-3742 Create OSGi bundle for Thymele...

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] servicemix-bundles pull request #129: SM-3742 Create OSGi bundle for Thymele...

oliverlietz
GitHub user oliverlietz opened a pull request:

    https://github.com/apache/servicemix-bundles/pull/129

    SM-3742 Create OSGi bundle for Thymeleaf 3.0.9

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/oliverlietz/servicemix-bundles SM-3742

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/servicemix-bundles/pull/129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #129
   
----
commit f7f11cfd8c86e33013a7e6afb3568800f0b4af59
Author: Oliver Lietz <olli@...>
Date:   2018-06-12T20:43:48Z

    SM-3742 Create OSGi bundle for Thymeleaf 3.0.9

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] servicemix-bundles pull request #129: SM-3742 Create OSGi bundle for Thymele...

oliverlietz
Github user jbonofre commented on a diff in the pull request:

    https://github.com/apache/servicemix-bundles/pull/129#discussion_r196436223
 
    --- Diff: thymeleaf-3.0.9.RELEASE/pom.xml ---
    @@ -0,0 +1,93 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +
    +  <!--
    +
    +      Licensed to the Apache Software Foundation (ASF) under one or more
    +      contributor license agreements.  See the NOTICE file distributed with
    +      this work for additional information regarding copyright ownership.
    +      The ASF licenses this file to You under the Apache License, Version 2.0
    +      (the "License"); you may not use this file except in compliance with
    +      the License.  You may obtain a copy of the License at
    +
    +         http://www.apache.org/licenses/LICENSE-2.0
    +
    +      Unless required by applicable law or agreed to in writing, software
    +      distributed under the License is distributed on an "AS IS" BASIS,
    +      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +      See the License for the specific language governing permissions and
    +      limitations under the License.
    +  -->
    +
    +  <modelVersion>4.0.0</modelVersion>
    +
    +  <parent>
    +    <groupId>org.apache.servicemix.bundles</groupId>
    +    <artifactId>bundles-pom</artifactId>
    +    <version>13</version>
    +    <relativePath>../bundles-pom/pom.xml</relativePath>
    +  </parent>
    +
    +  <artifactId>org.apache.servicemix.bundles.thymeleaf</artifactId>
    +  <version>3.0.9.RELEASE_1-SNAPSHOT</version>
    +  <packaging>bundle</packaging>
    +  <name>Apache ServiceMix :: Bundles :: ${pkgArtifactId}</name>
    +  <description>This OSGi bundle wraps ${pkgArtifactId} ${pkgVersion} jar file.</description>
    +
    --- End diff --
   
    For the record, `<scm/>` is required for the release. I'm fixing that anyway.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] servicemix-bundles pull request #129: SM-3742 Create OSGi bundle for Thymele...

oliverlietz
In reply to this post by oliverlietz
Github user oliverlietz commented on a diff in the pull request:

    https://github.com/apache/servicemix-bundles/pull/129#discussion_r196444227
 
    --- Diff: thymeleaf-3.0.9.RELEASE/pom.xml ---
    @@ -0,0 +1,93 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +
    +  <!--
    +
    +      Licensed to the Apache Software Foundation (ASF) under one or more
    +      contributor license agreements.  See the NOTICE file distributed with
    +      this work for additional information regarding copyright ownership.
    +      The ASF licenses this file to You under the Apache License, Version 2.0
    +      (the "License"); you may not use this file except in compliance with
    +      the License.  You may obtain a copy of the License at
    +
    +         http://www.apache.org/licenses/LICENSE-2.0
    +
    +      Unless required by applicable law or agreed to in writing, software
    +      distributed under the License is distributed on an "AS IS" BASIS,
    +      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +      See the License for the specific language governing permissions and
    +      limitations under the License.
    +  -->
    +
    +  <modelVersion>4.0.0</modelVersion>
    +
    +  <parent>
    +    <groupId>org.apache.servicemix.bundles</groupId>
    +    <artifactId>bundles-pom</artifactId>
    +    <version>13</version>
    +    <relativePath>../bundles-pom/pom.xml</relativePath>
    +  </parent>
    +
    +  <artifactId>org.apache.servicemix.bundles.thymeleaf</artifactId>
    +  <version>3.0.9.RELEASE_1-SNAPSHOT</version>
    +  <packaging>bundle</packaging>
    +  <name>Apache ServiceMix :: Bundles :: ${pkgArtifactId}</name>
    +  <description>This OSGi bundle wraps ${pkgArtifactId} ${pkgVersion} jar file.</description>
    +
    --- End diff --
   
    @jbonofre, I'm confused, sorry. Is an empty `<scm/>` required? See [this comment](https://github.com/apache/servicemix-bundles/pull/126#pullrequestreview-121849077).


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] servicemix-bundles pull request #129: SM-3742 Create OSGi bundle for Thymele...

oliverlietz
In reply to this post by oliverlietz
Github user jbonofre commented on a diff in the pull request:

    https://github.com/apache/servicemix-bundles/pull/129#discussion_r196445663
 
    --- Diff: thymeleaf-3.0.9.RELEASE/pom.xml ---
    @@ -0,0 +1,93 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +
    +  <!--
    +
    +      Licensed to the Apache Software Foundation (ASF) under one or more
    +      contributor license agreements.  See the NOTICE file distributed with
    +      this work for additional information regarding copyright ownership.
    +      The ASF licenses this file to You under the Apache License, Version 2.0
    +      (the "License"); you may not use this file except in compliance with
    +      the License.  You may obtain a copy of the License at
    +
    +         http://www.apache.org/licenses/LICENSE-2.0
    +
    +      Unless required by applicable law or agreed to in writing, software
    +      distributed under the License is distributed on an "AS IS" BASIS,
    +      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +      See the License for the specific language governing permissions and
    +      limitations under the License.
    +  -->
    +
    +  <modelVersion>4.0.0</modelVersion>
    +
    +  <parent>
    +    <groupId>org.apache.servicemix.bundles</groupId>
    +    <artifactId>bundles-pom</artifactId>
    +    <version>13</version>
    +    <relativePath>../bundles-pom/pom.xml</relativePath>
    +  </parent>
    +
    +  <artifactId>org.apache.servicemix.bundles.thymeleaf</artifactId>
    +  <version>3.0.9.RELEASE_1-SNAPSHOT</version>
    +  <packaging>bundle</packaging>
    +  <name>Apache ServiceMix :: Bundles :: ${pkgArtifactId}</name>
    +  <description>This OSGi bundle wraps ${pkgArtifactId} ${pkgVersion} jar file.</description>
    +
    --- End diff --
   
    No you should have the "regular" `<scm/>` section like:
   
    ```
        <scm>
            <connection>scm:git:https://git-wip-us.apache.org/repos/asf/servicemix-bundles.git</connection>
            <developerConnection>scm:git:https://git-wip-us.apache.org/repos/asf/servicemix-bundles.git</developerConnection>
            <url>https://git-wip-us.apache.org/repos/asf?p=servicemix-bundles.git</url>
      </scm>
    ```


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] servicemix-bundles pull request #129: SM-3742 Create OSGi bundle for Thymele...

oliverlietz
In reply to this post by oliverlietz
Github user asfgit closed the pull request at:

    https://github.com/apache/servicemix-bundles/pull/129


---